• Potatos_are_not_friends@lemmy.world
      link
      fedilink
      arrow-up
      43
      arrow-down
      1
      ·
      2 months ago

      Both sides.

      I constantly call out juniors who do things like ignore warnings, completely unaware that the warning is going to cause serious tech debt in a few months.

      But Ive also unfortunately shrugged after seeing hundreds of warnings because to update this requires me to go through 3 layers of departments and we’re still waiting on these six other blockers.

      Pick and choose I guess.

      • bitchkat@lemmy.world
        link
        fedilink
        English
        arrow-up
        9
        ·
        2 months ago

        Then things will have to wait until the code is of sufficient quality to be accepted.

    • gravitas_deficiency@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      1 month ago

      Yeah I’m one of the “I only want to write this fucker once so I will make it as solid as I can” types… and my manager/team-lead/principal dev (all the same person - that’s a whole other story) is the “yolo send it” type.

      We do not get on well. I’m probably going to switch teams or jobs soon.

  • bitchkat@lemmy.world
    link
    fedilink
    English
    arrow-up
    39
    arrow-down
    1
    ·
    2 months ago

    My experience is exactly the opposite. I don’t work for a FAANG but I’ve been around the block a bit. Its always the junior devs that try and add new warnings etc to the code base. I always require warnings to be cleaned up even if that means disabling specific instances (but not the whole rule) because the rule is flagging a false negative.

      • bitchkat@lemmy.world
        link
        fedilink
        English
        arrow-up
        2
        arrow-down
        16
        ·
        2 months ago

        Warnings and errors are negatives not positive. So if it generates a warning that is OK, it’s a false negative.

        • pantyhosewimp@lemmynsfw.com
          link
          fedilink
          arrow-up
          20
          ·
          2 months ago

          Just so you know, if your doctor calls and tells you that your HIV test is positive, you probably shouldn’t run out and celebrate.

          • bitchkat@lemmy.world
            link
            fedilink
            English
            arrow-up
            1
            arrow-down
            7
            ·
            2 months ago

            That’s why I said false negative. The medical test is testing for the presence of a disease. So if they find the disease is considered a positive test (it found what it was looking for). For static analysis on code, its the opposite. Its testing if your code is free of issues that it can detect. If it finds no issues, then the test was positive. If does find issues, the test failed and each issue is a negative that contributed to the test failing.

            • pantyhosewimp@lemmynsfw.com
              link
              fedilink
              arrow-up
              12
              ·
              2 months ago

              I’m not debating. It is not a matter of opinion. I’m doing you the courtesy of informing you how the entire rest of the world uses the term.

              If action A looks for thing X, and it finds thing X, then the test is positive. If action A fails to find thing X, then the test is negative.

              If action A claims to find thing X, but later confirmation determines that thing X is not really there, then this situation is called “false positive”.

              If action A claims fails to find thing X, but later confirmation determines that thing X is actually there, then this situation is called “false negative”.

              That thing X may subjectively be considered an unwanted outcome has **nothing ** to do with the terms used.

            • overcast5348@lemmy.world
              link
              fedilink
              arrow-up
              1
              ·
              2 months ago

              You could say “A static analysis tool is testing for the for the presence of defects” or “a medical test is testing if your body is free of diseases that it can detect” to change how you’re looking at either of the tests in the previous comment.

              • bitchkat@lemmy.world
                link
                fedilink
                English
                arrow-up
                1
                arrow-down
                2
                ·
                2 months ago

                By your logic it would be a positive for your code to have errors/warnings. And on the latter, that would appropriate if there was a test that determined if you are free from all known diseases (or at least those that it can detect).

                • overcast5348@lemmy.world
                  link
                  fedilink
                  arrow-up
                  8
                  ·
                  2 months ago

                  Is it a positive to have pathogens that cause dengue/malaria in your blood? Yet we still say that someone tested positive for dengue if they have the virus.

                  Static analysis tools don’t test for all known issues either, no?

                  It’s all just semantics dude. :)

    • gravitas_deficiency@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      1
      ·
      1 month ago

      It boils down to desensitization/normalization. Warnings (and errors, of course, but tests as well) exist for a reason. If you don’t care about these gauge constructs are telling you, then they have no real diagnostic value. Getting into a place where you’re not looking at how your systems are actually running is generally a bad idea, especially in the long run.

    • CanadaPlus@lemmy.sdf.org
      link
      fedilink
      arrow-up
      0
      ·
      edit-2
      2 months ago

      But financially bussin’!

      And also, it’s actually a complicated question. A one-man boycott doesn’t do anything. If you work at a FAANG, work for a better world when you’re off, and go whistleblower when they do something really evil, I find no fault in that at all.

        • CanadaPlus@lemmy.sdf.org
          link
          fedilink
          arrow-up
          0
          ·
          2 months ago

          Agreed. Just working for somebody bad doesn’t necessarily mean you’ve given up, though. I mean, they made a movie about Schindler, and we all know who he worked for.

            • masterspace@lemmy.ca
              link
              fedilink
              English
              arrow-up
              0
              arrow-down
              1
              ·
              2 months ago

              Saying things aren’t comparable is just shorthand for saying “I’ve stopped thinking or considering this”.

              Literally everything is comparable, especially an antifascist and the person they’re covering as.